[ scummvm-Patches-1280643 ] Possible Kyra fix

[SourceForge.net]

Patches item #1280643, was opened at 2005-09-02 15:30
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418822&aid=1280643&group_id=37116

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Torbjörn Andersson (eriktorbjorn)
Assigned to: Nobody/Anonymous (nobody)
Summary: Possible Kyra fix

Initial Comment:
Lately, the Kyrandia 1 intro has been crashing for me
in drawShape() because assert(shapeData) failed.

This is because when seq_setPanPages() is called to
create the hand shapes, the 'data' pointer points to
the following data in my copy of the game:

03 00 10 00 00 00 59 0a 00 00 44 14 00 00 3a 1e

"03 00" is the number of shapes. The offset is read by
READ_LE_UINT16(data + 2 + shape * 2), so the offsets
are "10 00", "00 00", and "59 0a". And that's the
problem: The second offset is 0, so that pointer will
be NULL.

Now, it looks to me as if the offsets are actually
32-bit quantities, i.e. the offsets are "10 00 00 00",
"59 0a 00 00" and "44 14 00 00", in which case the
attached patch should fix it. But I don't know if
that's really true even for my version of Kyrandia 1,
let alone any other version.


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418822&aid=1280643&group_id=37116