[ scummvm-Bugs-1470197 ] SCUMM: HE Game variants broken

[SourceForge.net]

Bugs item #1470197, was opened at 2006-04-14 12:05
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418820&aid=1470197&group_id=37116

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Launcher/Install
Group: All Games
Status: Open
Resolution: None
Priority: 9
Submitted By: kirben (kirben)
Assigned to: Max Horn (fingolfin)
Summary: SCUMM: HE Game variants broken

Initial Comment:
ScummVM 0.9.0svn (Apr 14 2006 11:43:23)
Compiled with GCC 3.4.5 under mingw.
Running on Windows XP Home Edition.

All HE71+ games, that use the generic HE variants 
currently fail under ScummVM, since revision 21768 of 
SVN. The default game is always choosen, instead of 
the HE generic variant.

The problem occrs when computing the precise game 
settings using 'gameVariantsTable'. The 'g->variant == 
0' check, causes the default game to always be choosen 
in these cases.

If I change the current check of:
if (g->variant == 0 || !scumm_stricmp(elem->variant, g-
>variant))
to
if (g->variant != 0 && !scumm_stricmp(elem->variant, g-
>variant))

The HE games using generic HE variants work fine 
again, but that excludes any games without multiple 
variants.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418820&aid=1470197&group_id=37116