[ scummvm-Patches-1485921 ] KYRA1: Fix (?) for odd-looking bitflag handling

SourceForge.net noreply at sourceforge.net
Wed May 10 22:17:30 CEST 2006


Patches item #1485921, was opened at 2006-05-10 22:17
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418822&aid=1485921&group_id=37116

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Torbjörn Andersson (eriktorbjorn)
Assigned to: Nobody/Anonymous (nobody)
Summary: KYRA1: Fix (?) for odd-looking bitflag handling

Initial Comment:
I've been itching to make this change, but I don't know
whether or not it's correct, or what difference it
would make.

In refreshSceneAnimObject(), we currently check unkFlag
and flipX and, for each of them, we either set one bit
in anim.flags, or we clear most of them. In fact, if
both unkFlag and flipX are zero, it looks to me as if
anim.flags will also end up zero.

It would make more sense to me if each of these
variables set and cleared only one bit. But, as I said,
I do not know what would happen if I made that change.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418822&aid=1485921&group_id=37116




More information about the Scummvm-tracker mailing list