[ scummvm-Bugs-1493475 ] FF: ADPCM sound is broken in DXA cutscenes

[SourceForge.net]

Bugs item #1493475, was opened at 2006-05-23 12:02
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418820&aid=1493475&group_id=37116

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Unknown Crash/Other
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Torbjörn Andersson (eriktorbjorn)
Assigned to: Nobody/Anonymous (nobody)
Summary: FF: ADPCM sound is broken in DXA cutscenes

Initial Comment:
It has been known for some time now that ADPCM-sound is
not supported in The Feeble File's DXA cutscenes. I
think I see why, but I can't decide on what's the
correct way of fixing it. As far as I can tell, the
problem is twofold:

* The startSound() function in FF's DXA player uses
makeWAVStream() to create a WAV stream from a memory
stream. Then it frees the original memory buffer, so it
assumes that makeWAVStream() will make a copy of the
data. The memory stream is a local variable.

* In the case of ADPCM files, an ADPCM stream is
created from the memory stream. The data is not copied.

So, unless I'm mistaken, when the mixer tries to stream
the sound from the WAV stream, the memory stream is no
longer alive, and even if it was alive it would point
to a memory block that has been freed.