[ scummvm-Bugs-1692142 ] LOOM: Intro crash (regression)

SourceForge.net noreply at sourceforge.net
Sun Apr 1 00:23:45 CEST 2007


Bugs item #1692142, was opened at 2007-04-01 00:23
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418820&aid=1692142&group_id=37116

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Unknown Crash/Other
Group: Loom Floppy
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Torbjörn Andersson (eriktorbjorn)
Assigned to: Nobody/Anonymous (nobody)
Summary: LOOM: Intro crash (regression)

Initial Comment:
Latest SVN snapshot
English floppy version of Loom

The changes in revision 26331 appear to have caused some regressions after all. The EGA Loom intro crashes early when trying to load costume 164.

It appears to be some kind of signed/unsigned issue. In loadResource(), fileOffs used to be set to 55143. Now it's set to -10393 instead.

It's a bit too late at night for me to figure this out, but my deranged imagination suggests that when ScummVM was modified to read roomoffs[][] with readSint16LE() instead of readUint16LE(), an assumption was made that the value would either fit in a signed 16-bit integer, or be -1. Clearly, in this case this was not true.

The bug could very well affect other games, but so far I haven't seen it happen anywhere else.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418820&aid=1692142&group_id=37116




More information about the Scummvm-tracker mailing list