[ scummvm-Bugs-1635361 ] CMI: Music fade-out broken for compressed audio

[SourceForge.net]

Bugs item #1635361, was opened at 2007-01-14 21:52
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418820&aid=1635361&group_id=37116

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: iMuse/Music
Group: Monkey Island 3
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Torbjörn Andersson (eriktorbjorn)
Assigned to: Nobody/Anonymous (nobody)
Summary: CMI: Music fade-out broken for compressed audio

Initial Comment:
Current ScummVM SVN snapshot.
English version of the game.

I discussed this with aquadran a bit the other day, but just so that it won't be forgotten:

Usually (always?) when a piece of music ends and another one begins, the game fades down the first piece of music rather than stopping it abruptly. But when using compressed audio files, the music jumps to the beginning of the track just as it's beginning to fade out.

As far as I can tell, the bug does not happen with the original (uncompressed) audio files. Though even there, there might be a slight skip when the sound is "cloned" from one track to another. It's hard to hear for sure.

One good place to observe this is early in the game, after you've managed to get Wally away from the cannon. Both the indoors and outdoors music have fairly distinctive starts, so simply walk between the two rooms and listen carefully to what happens.

I think the reason for this is the rather unusual way Digital iMUSE handles fading out. Although there is code present to fade any track up or down, when a track is set to fade out and die, it is "cloned" to a completely different track. See the cloneToFadeOutTrack() function for details. I guess the new audio stream isn't re-positioned to the point the old one was.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418820&aid=1635361&group_id=37116