[ scummvm-Bugs-1726115 ] FREDDI1: Tiny graphics glitch when reading message

[SourceForge.net]

Bugs item #1726115, was opened at 2007-05-26 16:56
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418820&aid=1726115&group_id=37116

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Torbjörn Andersson (eriktorbjorn)
Assigned to: Nobody/Anonymous (nobody)
Summary: FREDDI1: Tiny graphics glitch when reading message

Initial Comment:
Latest ScummVM snapshot
Swedish Freddi Fish 1

When Freddi and Luther read the message in a bottle, there's a tiny graphics glitch at the moment where Luther says he's going to be rich. See screenshot at http://www.update.uu.se/~d91tan/ScummVM/freddi.png

The glitch is the black pixels left in Freddi's eyes, and possibly at the right side of her mouth as well. Since this happens at the very beginning of the game, I'm not attaching a savegame.

This is probably the relevant part of script-45 (I had to use the undocumented -9 option to descumm it):

[086E] (5D) if (localvar0) {
[0874] (C9)   kernelSetFunctions.queueAuxBlock([VAR_EGO])
[087C] (C9)   kernelSetFunctions.queueAuxBlock([localvar2])
[0884] (61)   drawObject.setState(952,1)
[088B] (9D)   actorOps.setCurActor(VAR_EGO)
[0890] (9D)   actorOps.setAnimVar(0,0)
[0896] (9D)   actorOps.setCurActor(VAR_EGO)
[089B] (9D)   actorOps.setTalkPos(-220,50)
[08A2] (9D)   actorOps.setTalkColor(216)
[08A6] (9D)   actorOps.setTalkieSlot(1,"@T4618797,26778 at I'm going to be rich when I find that treasure!")
[08EE] (82)   animateActor(VAR_EGO,9)
[08F4] (82)   animateActor(localvar2,7)
[08FA] (82)   animateActor(localvar3,10)
[0900] (5C)   until (getAnimateVariable(VAR_EGO,0)) {
[0909] (6C)     breakHere()
[090A] (**)   }
[090D] (**) }

Which leads me to think that maybe there's an off-by-one error when ScummEngine_v71he::preProcessAuxQueue() restores the background. If I add 1 to the right and bottom of the rectangle, the glitch goes away. Of course, I'm not saying that this is necessarily the right way of fixing it.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418820&aid=1726115&group_id=37116