[ scummvm-Bugs-1726330 ] SCUMM engine abuses stack

[SourceForge.net]

Bugs item #1726330, was opened at 2007-05-27 18:53
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418820&aid=1726330&group_id=37116

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: MD5 checksums / Detector
Group: None
Status: Open
Resolution: None
Priority: 9
Private: No
Submitted By: Jonathan Gray (khalek)
Assigned to: Nobody/Anonymous (nobody)
Summary: SCUMM engine abuses stack

Initial Comment:
When trying to start any SCUMM based game the code abuses the stack, which will result in anything using a stack protector to kill the application.

For example trying to start a game on OpenBSD/amd64 4.1-current gives:

#0  0x000000004b245eea in kill () from /usr/lib/libc.so.40.3
#1  0x000000004b268ac0 in __stack_smash_handler (
    func=0x9af940 "void Scumm::detectGames(const FSList&, Common::List<Scumm::DetectorResult>&, const char*)", damaged=6)
    at /usr/src/lib/libc/sys/stack_protector.c:89
#2  0x000000000041691b in detectGames (fslist=@0x7f7ffffc4650, 
    results=@0x7f7ffffc4680, gameid=0x46b67f50 "monkey")
    at engines/scumm/detection.cpp:443
#3  0x0000000000417b9c in Engine_SCUMM_create(OSystem*, Engine**) (
    syst=0x4a609800, engine=0x7f7ffffc4868) at engines/scumm/detection.cpp:791
#4  0x000000000041537a in StaticPlugin::createInstance(OSystem*, Engine**) const (this=0x50354280, syst=0x4a609800, engine=0x7f7ffffc4868)
    at base/plugins.cpp:49
#5  0x000000000040c7eb in runGame (plugin=0x50354280, system=@0x4a609800, 
    edebuglevels=@0x7f7ffffc4bd0) at base/main.cpp:140
#6  0x000000000040d24a in scummvm_main (argc=4, argv=0x7f7ffffc4cb8)
    at base/main.cpp:297
#7  0x000000000040a5d1 in main (argc=4, argv=0x7f7ffffc4cb8)
    at backends/platform/sdl/sdl.cpp:121

This does not happen with other engines, this did not happen with 0.9.1.

I do not have time to do the figuring out where it broke dance right now, but clearly it is broken.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418820&aid=1726330&group_id=37116