[ scummvm-Patches-1825276 ] DETECTION: advanced detector engine simplification

[SourceForge.net]

Patches item #1825276, was opened at 2007-11-03 20:25
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418822&aid=1825276&group_id=37116

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Gregory Montoir (cyx)
Assigned to: Eugene Sandulenko (sev)
Summary: DETECTION: advanced detector engine simplification

Initial Comment:

Here is a patch to simplify the detection code of some engines relying on AdvancedDetector.

Currently, when an engine starts, AdvancedDetector::detectGameForEngineCreation is called, followed by AdvancedDetector::detectBestMatchingGame. Does running the detection process 2 times really necessary ?

Bsically, all this patch does is :
- replace any use of ADVANCED_DETECTOR_DEFINE_PLUGIN by ADVANCED_DETECTOR_DEFINE_PLUGIN_WITH_COMPLEX_CREATION
- removed detectGame/initGame helper functions in engines using ADVANCED_DETECTOR_DEFINE_PLUGIN_WITH_COMPLEX_CREATION (as the gameDescription is already available)
- add the missing call to upgradeTargetIfNecessary in ADVANCED_DETECTOR_DEFINE_PLUGIN_WITH_COMPLEX_CREATION
- remove the code related to detectGameForEngineCreation
- rename ADVANCED_DETECTOR_DEFINE_PLUGIN_WITH_COMPLEX_CREATION to ADVANCED_DETECTOR_DEFINE_PLUGIN


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418822&aid=1825276&group_id=37116