[ scummvm-Patches-2050337 ] KYRA/SCUMM: Thumbnail support/improvement

[SourceForge.net]

Patches item #2050337, was opened at 2008-08-14 00:12
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418822&aid=2050337&group_id=37116

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Johannes Schickel (lordhoto)
Assigned to: Johannes Schickel (lordhoto)
Summary: KYRA/SCUMM: Thumbnail support/improvement

Initial Comment:
Hi,

this patch adds thumbnail support to the kyra engine. To achieve this it moves out most of the former SCUMM specific thumbnail save format to a common API (found in graphics/thumbnail.h). It also changes SCUMM to use the new API to load/save thumbnails.

There are some things which should be discussed before this patch will be committed:

The patch contains support for optional thumbnail entries in save files, it is implemented via backward seeking if no valid header is found. Since our compressed save files do not support backward seeking, it will not be working properly right now. (See TODOs in engines/scumm/thumbnail.cpp) The question about this issue is: Do we want savegames without thumbnails? For example the Nintendo DS port does not create any thumbnails currently, it only saves a plain black rect as thumbnail. With the newly added code, the thumbnail could be simply left out for it.

Also do we really want thumbnail save/load to be done via a common API? I think it is easier to support thumbnails in other engines with it. Also we have some well tested and useable API for it then.

-

Another side note about the patch, I wasn't actually able to test the thumbnails saved from kyra in real world yet, since the kyra dialog does not use the overlay thus, it is not possible to display thumbnails. And I was too lazy to write a simple displayer yet ;-), I suspect it working though. At least there should be no issues with the newly added common API for thumbnails, I tested it with SCUMM and everything works fine for me.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418822&aid=2050337&group_id=37116