[ scummvm-Patches-1885901 ] Two different fixes for NASM warnings

[SourceForge.net]

Patches item #1885901, was opened at 2008-02-03 22:21
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418822&aid=1885901&group_id=37116

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Torbjörn Andersson (eriktorbjorn)
Assigned to: Nobody/Anonymous (nobody)
Summary: Two different fixes for NASM warnings

Initial Comment:
The latest version of NASM (2.01) produces lots and lots of warnings about lines with only a label, and no colon at the end. The colon is supposed to be optional, and earlier versions didn't warn me about it.

There are two possible fixes:

1) Add the "missing" colons.
2) Add -w-orphan-labels to NASMFLAGS

Strangely enough, we already do the latter. But only for MinGW and CygWin. That's one reason why I'm uncertain which is the preferred fix.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418822&aid=1885901&group_id=37116