[ scummvm-Patches-1869152 ] MAEMO port preliminary patch

[SourceForge.net]

Patches item #1869152, was opened at 2008-01-11 10:55
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418822&aid=1869152&group_id=37116

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Frantisek Dufka (fanous)
Assigned to: Nobody/Anonymous (nobody)
Summary: MAEMO port preliminary patch

Initial Comment:
OK, this is not finished but at least you can give some comments

debian directory - Maemo is debian based so I'm not sure where to put it since debian port already exists, perhaps I can put it to  backends/platform/maemo/debian?

configure - i am using tremor and FLAC and FLAC is build without ogg so with -logg the build fails 

sword1 and 2 - keymapping (see http://maemo.org/community/wiki/scummvm/ for explanations) can be moved to remapKey in platform/sdl/events.cpp 

scumm - cannot be moved easily - how can I check for specific active engine (i.e. scumm) and the its version in platform/sdl/events.cpp? I am not interested in specific game.

Touche - in original you need to hold right button and release it - mapped to center key and (which may be useful elsewhere) you can just (right) click for menu popup and left click for selecting item and closing menu

CINE 0.10 to 0.11 move is unfinished yet but seems trivial

backends/plugins/sdl/sdl-provider.cpp - i tried to build plugins too, it produced bigger code in total so I disabled it back. But noticed that plugins dir is hardcoded to plugins/ so it is searched in /usr/games/bin/plugins which is not ideal, added variable so i could move it somewhere else. Can be ignored.

backends/platform/sdl/events.cpp - I have added setMousePos(event.mouse.x, event.mouse.y); call to  case SDL_MOUSEBUTTONDOWN since without any mousemotion events it may not be updated at all and click is done at wrong coordinates (?) I'm not sure about it but I think it improved situation with CINE engine at least.

Lure - mapping is done in platform/sdl/events.cpp but it is not ideal so I will probably move it out. need to map center key differently in save dialog

As for moving keymapping out of engines there are issues - I need to access private data of specific engine (scummvm), sometimes I need to map keys differently in some parts of game - center key (=Enter/ascii 13) to right click in main view but to Enter in save game dialog.

So if there will be generic keymapper it would need something like game domain parameter added (and passed to pollevent from engine) so the keymapping code knows which set of keymapping is needed to which part of the game. I will make the final patch over the weekend and submit it here hopefully Sunday evening. It will consist of dirty patch that should be commited to backends/platform/maemo/ as a file for (later patching) and 'clean' version which will patch backends/platform/maemo/ and add README makefile etc.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418822&aid=1869152&group_id=37116