[ scummvm-Bugs-2284199 ] IGOR: Strange code in drawInventory()

[SourceForge.net]

Bugs item #2284199, was opened at 2008-11-14 15:20
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418820&aid=2284199&group_id=37116

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Unknown Crash/Other
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Torbjörn Andersson (eriktorbjorn)
Assigned to: Nobody/Anonymous (nobody)
Summary: IGOR: Strange code in drawInventory()

Initial Comment:
Current ScummVM CVS:

While building ScummVM with the -O2 compiler option, I ran into the following warning:

engines/igor/igor.cpp: In member function ‘void Igor::IgorEngine::drawInventory(int, int)’:
engines/igor/igor.cpp:1308: warning: assuming signed overflow does not occur when assuming that (X + c) >= X is always true

This is the part of drawInventory() that GCC complains about:

    int end = start + 6;
    if (start <= end) {

Is this deliberate behaviour? It seems risky, at best.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418820&aid=2284199&group_id=37116