[ scummvm-Patches-2201951 ] Gamma support

[SourceForge.net]

Patches item #2201951, was opened at 2008-10-27 23:37
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418822&aid=2201951&group_id=37116

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Filippos Karapetis (thebluegr)
Assigned to: Nobody/Anonymous (nobody)
Summary: Gamma support

Initial Comment:
This is a patch that adds gamma support and a gamma slider to ScummVM's options (part of feature request #2116244). It does this by calling SDL_SetGamma, so it's done in hardware level, and it doesn't affect any engine

It's working, though there are still some unfinished things:
- The gamma value is not set yet when ScummVM is loaded
- Currently, the gamma values range from 0-200 (or 0.0 to 2.0). I'm not sure about the actual maximum value, though 2.0 seems to be very bright
- When the options dialog pops up, the initial value of the slider is not set correctly
- I'm not sure if the graphics tab is a good place to put the slider, as it contains per-game options. Perhaps the misc tab would be more appropriate?
- I haven't documented functions setGamma() and resetGamma() in system.h
- SDL_SetGamma() accepts a float, which is what setGamma() accepts. I'm not sure if there should be any floats in system.h, in case it's used by systems where floats are not supported (one of the reasons I haven't documented the function). Perhaps it would be wiser to change the float parameter to an integer (which would be the current parameter multiplied by 100)

Also, note that the XML theme files contain the save/load buttons from the common load dialog patch, which are not needed in this patch, I just haven't removed them (and I was hesitant to edit the actual patch file itself, in case I break it)

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418822&aid=2201951&group_id=37116