[ scummvm-Patches-2602772 ] Patches for bug ID #1977094

SourceForge.net noreply at sourceforge.net
Sun Feb 15 15:43:21 CET 2009


Patches item #2602772, was opened at 2009-02-15 14:43
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418822&aid=2602772&group_id=37116

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Thierry Crozat (criezy)
Assigned to: Nobody/Anonymous (nobody)
Summary: Patches for bug ID #1977094

Initial Comment:
It seems I cannot post files directly in the bug report, therefore I am posting them here instead.

The two patches both solve bug #1977094 (error displayed instead of subtitle in Syria).
The original issue is that the sentence is missing from the text cluster file for some languages (German, French and Spanish). This is correctly caught in ScummVM BS1 engine, but it replaces the missing subtitle by an error string.

The first patch replaces missing subtitles by an empty string, therefore no subtitles are displayed (there is still a warning in the console).

The second patch contains the first one and in addition hardcode the subtitles for that particular sentence. Actually I have only done it for the French language as I don't know what the subtitle should be for the German or Spanish languages. Therefore this patch needs to be completed by somebody who knows what the subtitle should be in these languages (there is a static string array to complete at the end of objectman.cpp file).

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418822&aid=2602772&group_id=37116




More information about the Scummvm-tracker mailing list