[ scummvm-Bugs-2710315 ] INDY3/FOA: bug in patch for series IQ with ScummVM GUI

[SourceForge.net]

Bugs item #2710315, was opened at 2009-03-24 21:09
Message generated for change (Tracker Item Submitted) made by tobigun
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418820&aid=2710315&group_id=37116

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: Indiana Jones 4
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Tobias Gunkel (tobigun)
Assigned to: Nobody/Anonymous (nobody)
Summary: INDY3/FOA: bug in patch for series IQ with ScummVM GUI

Initial Comment:
Zlorfik!

In my patch "INDY3/FOA: series IQ with ScummVM GUI" (ID: 2676453; already committed and closed) there was a bug.

byte saveLoad = (_saveLoadFlag != 0);

must be

byte saveLoad = _saveLoadFlag;

Otherwise "saveLoad == 2" is never true. saveLoad was a boolean var first and changed later to byte without me recognizing that it was broken. 

Sorry.

I've added a patch for fixing this. By this, I've also changed the type of puzzleIQ from char to byte as an unsigned type fits better (although the max. puzzle-IQ is 100, so it was not a bug).

Additionally I have documented byte 73 of the IQ-String which is used by the original script for IQ-point calculation but ignored by updateIQPoints(). It does not contain a puzzle's IQ but a flag that indicates if the IQ-file was loaded successfully (0 in this case, otherwise 0xFF but reset to 0 in script 9 before performing the IQ-point calculation). As it is always 0 on the IQ calculation it doesn't hurt but it shouldn't be used as done by the original script. 

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418820&aid=2710315&group_id=37116