[ scummvm-Patches-2982306 ] Tools GUI: fix use of mp3 AVR target bit rate

[SourceForge.net]

Patches item #2982306, was opened at 2010-04-05 21:04
Message generated for change (Tracker Item Submitted) made by criezy
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418822&aid=2982306&group_id=37116

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Thierry Crozat (criezy)
Assigned to: Nobody/Anonymous (nobody)
Summary: Tools GUI: fix use of mp3 AVR target bit rate

Initial Comment:
Reviewing my patch #2981339 I noticed I made a mistake. The CompresionTool store the VBR minimum bit rate and the ABR target bit rate in the same variable. Because the GUI Tools now pass both to the CompressionTool and the second one is the VBR minimum bit rate, when encoding using MP3 ABR it will use the bit rate specified in the disabled VBR minimum bit rate combobox instead of the one from the ABR target bit rate combobox.
This patch fixes this by setting either the ABR target bit rate or the VBR minimum and maximum bit rates in the CompresionTool depending if the user chose ABR or VBR.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418822&aid=2982306&group_id=37116