[ scummvm-Patches-2986300 ] MAKEFILE: Fix builds when no engine-data is used

SourceForge.net noreply at sourceforge.net
Tue Apr 13 08:38:09 CEST 2010


Patches item #2986300, was opened at 2010-04-13 01:38
Message generated for change (Tracker Item Submitted) made by dxq
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418822&aid=2986300&group_id=37116

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: GSoC
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Dylan Edwards (dxq)
Assigned to: Nobody/Anonymous (nobody)
Summary: MAKEFILE: Fix builds when no engine-data is used

Initial Comment:
Currently, several platforms will fail in the final steps of a build if you have opted not to build any engines that require engine data. This is due to lines similar to the following in ports.mk:

cp $(DIST_FILES_ENGINEDATA) $(bundle_name)/Contents/Resources/

Where $DIST_FILES_ENGINEDATA is empty, causing cp to fail (it's only being provided with one argument).

My patch simply adds an ifdef $(DIST_FILES_ENGINEDATA) before the suspect lines.

As far as I can tell, DIST_FILES_ENGINEDATA is the only value that can be left undefined by the configure process that causes this issue.

This patch is against the most current trunk as of writing, r48650.



----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418822&aid=2986300&group_id=37116




More information about the Scummvm-tracker mailing list