[ scummvm-Bugs-2948858 ] MP3 (CD Audio) Broken under SVN

[SourceForge.net]

Bugs item #2948858, was opened at 2010-02-09 23:16
Message generated for change (Tracker Item Submitted) made by mthreepwood
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418820&aid=2948858&group_id=37116

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: SFX/Talkie
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: clone2727 (mthreepwood)
Assigned to: Nobody/Anonymous (nobody)
Summary: MP3 (CD Audio) Broken under SVN

Initial Comment:
Mac OS X 10.5 (x86), HEAD revision (r48028 at time of writing)
Loom VGA CD, MP3 compressed audio

The audio does not play under the head revision right now. I dug a little into it, and I've tracked it to decodeMP3Data(). At the end of the function, there are these lines:

if (_stream.error != MAD_ERROR_NONE)
	_state = MP3_STATE_EOS;

At this point, _stream.error is MAD_ERROR_LOSTSYNC and therefore, since _state is now MP3_STATE_EOS, endOfData() will return true and then makeMP3Stream() will return 0. Commenting these two lines out makes sound work again. I'm not sure what is supposed to happen here or what change recently broke this.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418820&aid=2948858&group_id=37116