[ scummvm-Patches-2929000 ] Tools: workaround for make 3.80 bug
SourceForge.net
noreply at sourceforge.net
Sat Jan 9 23:17:18 CET 2010
Patches item #2929000, was opened at 2010-01-09 22:17
Message generated for change (Tracker Item Submitted) made by criezy
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=418822&aid=2929000&group_id=37116
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Thierry Crozat (criezy)
Assigned to: Nobody/Anonymous (nobody)
Summary: Tools: workaround for make 3.80 bug
Initial Comment:
The tools fail to build with make 3.80 because it triggers a "virtual memory exhausted" error. This is a known bug triggered by
$(eval $foo)
when $foo is too long.
In that case the bug is triggered by the code on line 240 of Makefile.common:
$(foreach prog,$(PROGRAMS),$(eval $(call PROGRAM_template,$(prog))))
It creates the build and clean rules for each executable using the PROGRAM_template template.
The attached patch work around the make 3.80 bug by explicitly defining the rules for several executable instead of using the template. These executables have a lot of object files and this triggers the bug.
I am not sure this patch should be committed as it seems a bad hack that makes the Makefile.common file heavier and less easy to maintain. But in case somebody wants to compile the tools with make 3.80, the patch is at least in the tracker now.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=418822&aid=2929000&group_id=37116
More information about the Scummvm-tracker
mailing list