[ scummvm-Bugs-2929619 ] Small problem detecting German version

SourceForge.net noreply at sourceforge.net
Mon Jan 11 06:49:16 CET 2010


Bugs item #2929619, was opened at 2010-01-11 00:49
Message generated for change (Tracker Item Submitted) made by leonardoboshell
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418820&aid=2929619&group_id=37116

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: MD5 checksums / Detector
Group: I Have No Mouth
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Leonardo Boshell (leonardoboshell)
Assigned to: Nobody/Anonymous (nobody)
Summary: Small problem detecting German version

Initial Comment:
Hello,

I know this is just a small issue, but when the german version of IHNM is being added, the detector can't decide if it's the German or the French version, so it displays both in a list. Ideally, the German version should be detected directly.

Taking a look at the detection tables, I see that it's because these two versions (German and French) are being detected using the same files, which have the same md5sum's; however, the entries for the German version include the size of the scream.res file, but the entries for the French version don't. Incidentally, this means that if the french version is being added, it gets recognised correctly (it sees that it can't be the German version because of the file size), but the problem exists for the German version.

A solution would be to add the size of scream.res for the French version in the detection tables. I grabbed a copy of the french version just to test this out, and with that I made this patch which fixes the problem.

Thanks.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418820&aid=2929619&group_id=37116




More information about the Scummvm-tracker mailing list