[ scummvm-Patches-2973283 ] SCUMM: Unneeded pointer dereference

[SourceForge.net]

Patches item #2973283, was opened at 2010-03-19 17:49
Message generated for change (Tracker Item Submitted) made by salty-horse
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418822&aid=2973283&group_id=37116

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Ori Avtalion (salty-horse)
Assigned to: Nobody/Anonymous (nobody)
Summary: SCUMM: Unneeded pointer dereference

Initial Comment:
engines/scumm/gfx.cpp has this statement:

*smap_ptr++;

Since the increment (++) takes precedence over the pointer dereference (*), the dereference is pointless (pun not intended).
It's probably a copy-paste from the lines around it, which do make use of the dereference.

The attached patch removes the * from the offending lines.
I didn't test it.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418822&aid=2973283&group_id=37116