[ scummvm-Patches-3005384 ] BRA: correctly parse animations of type none

SourceForge.net noreply at sourceforge.net
Fri May 21 17:13:26 CEST 2010


Patches item #3005384, was opened at 2010-05-21 17:13
Message generated for change (Tracker Item Submitted) made by fuzzie
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418822&aid=3005384&group_id=37116

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Alyssa Milburn (fuzzie)
Assigned to: Nobody/Anonymous (nobody)
Summary: BRA: correctly parse animations of type none

Initial Comment:
r35783 removes a check for kZoneNone, this patch puts it back so that animations of type 'none' are parsed correctly (for example, so that COMMANDS blocks are picked up).

This is necessary for BRA. For example, take a look at scende2 inside PASSA.LOC, which turns the mouse cursor back on. Patch against trunk.

An alternative would be to fix parseZoneTypeBlock and all the parsing functions so that they handled the parser tables themselves if they didn't recognise a line, which would work in all circumstances. I'd be happy to try writing a patch to do that, if you'd prefer!

(The _parser->popTables() call is moved inside the if statement here, too, because otherwise the remaining contents of the animation aren't parsed correctly - shouldn't this also be the case for the other if statements with a parseZoneTypeBlock call inside them?)

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418822&aid=3005384&group_id=37116




More information about the Scummvm-tracker mailing list