[ scummvm-Patches-3006178 ] rjp1: calculate sample length correctly

SourceForge.net noreply at sourceforge.net
Mon May 24 01:14:41 CEST 2010


Patches item #3006178, was opened at 2010-05-24 01:14
Message generated for change (Tracker Item Submitted) made by fuzzie
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418822&aid=3006178&group_id=37116

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Alyssa Milburn (fuzzie)
Assigned to: Nobody/Anonymous (nobody)
Summary: rjp1: calculate sample length correctly

Initial Comment:
This fixes the RJP1 player to use the correct sample length - the length entry in the file is actually "length after provided position", it seems.

I couldn't find any specs, but I looked at the m68k player source I could find for the format, made this patch based on what it seemed it was doing, and then thought to check the start/end offsets within the data: they match the reasoning of this patch (i.e. the sample data is packed together if at this length) and the data seems correct, so I'm pretty sure this is correct.

This fixes bug 3001110, which was due to an assert since the playback was starting after the supposed end of samples. Patch against trunk.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418822&aid=3006178&group_id=37116




More information about the Scummvm-tracker mailing list