[ scummvm-Patches-3085298 ] overflows in agi and parallaction

[SourceForge.net]

Patches item #3085298, was opened at 2010-10-11 16:36
Message generated for change (Tracker Item Submitted) made by reddwarf69
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418822&aid=3085298&group_id=37116

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Cristian Morales Vega (reddwarf69)
Assigned to: Nobody/Anonymous (nobody)
Summary: overflows in agi and parallaction

Initial Comment:
_textColors is 1 byte short since there is code that access it up to kNormalColor (= 2)

The third parameter of strncat is related to the source string, not to the destination one.
Use sizeof() to not have the string size hardcoded in two different places.
At the end the NULL byte is places 1 byte too far.


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418822&aid=3085298&group_id=37116