[ scummvm-Bugs-3087825 ] AGI: Code analysis warnings

[SourceForge.net]

Bugs item #3087825, was opened at 2010-10-14 23:58
Message generated for change (Tracker Item Submitted) made by littleboy
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418820&aid=3087825&group_id=37116

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Compiler error
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Julien (littleboy)
Assigned to: Nobody/Anonymous (nobody)
Summary: AGI: Code analysis warnings

Initial Comment:
Here are the warnings I get when compiling the AGI engine using Code Analysis in VS2010.

I tried to remove all the obvious false positives. Some warnings look suspicious, others are pointing to correct code that still might benefit from better error checking.


d:\sources\scummvm\scummvm\engines\agi\preagi_mickey.cpp(311): warning C6011: Dereferencing NULL pointer 'sel'

d:\sources\scummvm\scummvm\engines\agi\preagi_mickey.cpp(1238): warning C6200: Index '9' is out of valid index range '0' to '8' for non-stack buffer 'IDS_MSA_ADDR_PLANET'

d:\sources\scummvm\scummvm\engines\agi\keyboard.cpp(315): warning C6202: Buffer overrun for '_lastSentence', which is possibly stack allocated, in call to 'strcpy': length '256' exceeds buffer size '40'


Note: If you want to try it yourself, you will need:
 - the create_project patch set, along with the WIP code analysis patch (http://bitbucket.org/Littleboy/scummvm-jt/src/942f13a9f24b )
 - the following patch to silence some false positives ( http://bitbucket.org/Littleboy/scummvm-jt/src/tip/COMMON%20-%20Add%20annotations%20for%20analysis%20build%20configuration.patch )
 - Visual Studio 2010 Ultimate or Team System (create_project support for analysis with VS2005/2008 isn't complete yet)

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418820&aid=3087825&group_id=37116