[ scummvm-Bugs-3087837 ] KYRA: Code analysis warnings

SourceForge.net noreply at sourceforge.net
Fri Oct 15 06:30:50 CEST 2010


Bugs item #3087837, was opened at 2010-10-15 00:30
Message generated for change (Tracker Item Submitted) made by littleboy
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418820&aid=3087837&group_id=37116

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Compiler error
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Julien (littleboy)
Assigned to: Nobody/Anonymous (nobody)
Summary: KYRA: Code analysis warnings

Initial Comment:
Here are the warnings I get when compiling the engine using Code Analysis in VS2010. I tried to remove all the obvious false positives. Some warnings look suspicious, others are pointing to correct code that still might benefit from better error checking.

d:\sources\scummvm\scummvm\engines\kyra\script_tim.cpp(950): warning C6011: Dereferencing NULL pointer 'wsa'
d:\sources\scummvm\scummvm\engines\kyra\sequences_lol.cpp(1438): warning C6291: Bitwise operation on logical result: ! has higher precedence than |. Use || or (!(x | y)) instead
d:\sources\scummvm\scummvm\engines\kyra\resource_intern.cpp(950): warning C6292: Ill-defined for-loop: counts up from maximum
d:\sources\scummvm\scummvm\engines\kyra\scene_lok.cpp(1108): warning C6011: Dereferencing NULL pointer 'curTable'
d:\sources\scummvm\scummvm\engines\kyra\items_lok.cpp(307): warning C6287: Redundant code: the left and right sub-expressions are identical

Note:
If you want to try it yourself, you will need:
 - the create_project patch set, along with the WIP code analysis patch (http://bitbucket.org/Littleboy/scummvm-jt/src/942f13a9f24b )
 - the following patch to silence some false positives ( http://bitbucket.org/Littleboy/scummvm-jt/src/tip/COMMON%20-%20Add%20annotations%20for%20analysis%20build%20configuration.patch )
 - Visual Studio 2010 Ultimate or Team System (create_project support for analysis with VS2005/2008 isn't complete yet)

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418820&aid=3087837&group_id=37116




More information about the Scummvm-tracker mailing list