[ scummvm-Bugs-3087922 ] COMMON/BASE/BACKENDS: Code analysis warnings

[SourceForge.net]

Bugs item #3087922, was opened at 2010-10-15 03:07
Message generated for change (Tracker Item Submitted) made by littleboy
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418820&aid=3087922&group_id=37116

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Compiler error
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Julien (littleboy)
Assigned to: Nobody/Anonymous (nobody)
Summary: COMMON/BASE/BACKENDS: Code analysis warnings

Initial Comment:
Here are the warnings I get when compiling using Code Analysis in VS2010. I tried to remove all the obvious false positives. Some warnings look suspicious, others are pointing to correct code that still might benefit from better error checking.

COMMON:
d:\sources\scummvm\scummvm\common\macresman.cpp(671): warning C6011: Dereferencing NULL pointer 'iconData'
d:\sources\scummvm\scummvm\common\algorithm.h(245): warning C4146: unary minus operator applied to unsigned type, result still unsigned
          d:\sources\scummvm\scummvm\sound\timestamp.cpp(35) : see reference to function template instantiation 'T Common::gcd<uint>(T,T)' being compiled
          with
          [
              T=uint
          ]
d:\sources\scummvm\scummvm\common\algorithm.h(246): warning C4146: unary minus operator applied to unsigned type, result still unsigned
(tthe last two are not code-analysis related and have been there for quite a long time)


BACKENDS:
d:\sources\scummvm\scummvm\backends\platform\sdl\sdl.cpp(384): warning C6031: Return value ignored: 'GetWindowsDirectoryA'
d:\sources\scummvm\scummvm\backends\platform\sdl\sdl.cpp(396): warning C6031: Return value ignored: 'GetWindowsDirectoryA'
d:\sources\scummvm\scummvm\backends\platform\sdl\sdl.cpp(527): warning C6031: Return value ignored: 'sscanf'
d:\sources\scummvm\scummvm\backends\platform\sdl\sdl.cpp(542): warning C6031: Return value ignored: 'sscanf'
d:\sources\scummvm\scummvm\backends\platform\sdl\sdl.cpp(548): warning C6031: Return value ignored: 'sscanf'
d:\sources\scummvm\scummvm\backends\platform\sdl\sdl.cpp(543): warning C6054: String 'color' might not be zero-terminated

BASE:
d:\sources\scummvm\scummvm\base\commandline.cpp(305): warning C6011: Dereferencing NULL pointer 'argv'

Note:
If you want to try it yourself, you will need:
 - the create_project patch set, along with the WIP code analysis patch (http://bitbucket.org/Littleboy/scummvm-jt/src)
 - the following patch to silence some false positives ( http://bitbucket.org/Littleboy/scummvm-jt/src/tip/COMMON%20-%20Add%20annotations%20for%20analysis%20build%20configuration.patch )
 - Visual Studio 2010 Ultimate or Team System (create_project support for analysis with VS2005/2008 isn't complete yet)





----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418820&aid=3087922&group_id=37116