[ scummvm-Bugs-3357096 ] SCI: kString(Dup) : Invalid pointer

[SourceForge.net]

Bugs item #3357096, was opened at 2011-07-06 23:44
Message generated for change (Tracker Item Submitted) made by lephilousophe
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418820&aid=3357096&group_id=37116

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Unknown Crash/Other
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Philippe Valembois - Phil (lephilousophe)
Assigned to: Nobody/Anonymous (nobody)
Summary: SCI: kString(Dup) : Invalid pointer

Initial Comment:
The source string pointer becomes invalid when a new string entry is allocated in the string table : the call to push_back moves the data to a new place and the old one gets erased. This makes the rawString pointer invalid and copied data is bad.
The bug can be seen in Torin's passage (CD/Windows/French) : the save data file has a name with garbage in it.
Attached is a fix proposal.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418820&aid=3357096&group_id=37116