[ scummvm-Bugs-3558052 ] SAGA: use-after-free warning

[SourceForge.net]

Bugs item #3558052, was opened at 2012-08-15 14:00
Message generated for change (Tracker Item Submitted) made by criezy
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418820&aid=3558052&group_id=37116

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Thierry Crozat (criezy)
Assigned to: Nobody/Anonymous (nobody)
Summary: SAGA: use-after-free warning

Initial Comment:
Compiling the SAGA engine with clang reports a use-after-free warning in shorten.cpp line 526 (at the end of loadShortenFromStream()).
I am not familiar with this engine and this might be a false positive, but the code looks very suspicious:

	if (size > 0)
		free(unpackedBuffer); // <- free

	delete gReader;
	return unpackedBuffer; // <- use after free


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418820&aid=3558052&group_id=37116