[Scummvm-tracker] [ScummVM] #10126: TITANIC: Star Puzzle, crash for unlocking 1st star after 2 locked

[dafioram]

#10126: TITANIC: Star Puzzle, crash for unlocking 1st star after 2 locked
-------------------------------+-----------------------------
  Reporter:  dafioram          |      Owner:  dreammaster
      Type:  defect            |     Status:  pending
  Priority:  low               |  Component:  Engine: Titanic
Resolution:  fixed             |   Keywords:
      Game:  Starship Titanic  |
-------------------------------+-----------------------------
Changes (by dafioram):

 * owner:  (none) => dreammaster
 * status:  new => pending
 * resolution:   => fixed


Comment:

 PR995 solves this.

 The logic in CStarCrosshairs::selectStar was allowing previously
 marked/locked stars to be deselected via the skymap. Now the code checks
 that that the new star selection is not already in the queue (_entries)
 unless it is the most recent one then that one can be removed since its
 not locked.

 It previously crashed if

 1. You had 2 stars locked on and you tried to remove the 1st
 2. Had 1 locked and 1 unlocked and you tried to unlock the 1st
 3. Had 2 locked and 1 unlocked and you tried to unlock any of the other
 two locked stars.

--
Ticket URL: <https://bugs.scummvm.org/ticket/10126#comment:2>
ScummVM <https://bugs.scummvm.org>
ScummVM