[Scummvm-tracker] [ScummVM] #10154: MSVC 2015 - SCI does not build, STATIC_ASSERT broken?

[Quietust]

#10154: MSVC 2015 - SCI does not build, STATIC_ASSERT broken?
---------------------+-------------------------
Reporter:  quietust  |      Owner:  (none)
    Type:  defect    |     Status:  new
Priority:  normal    |  Component:  Engine: SCI
Keywords:            |       Game:
---------------------+-------------------------
 When building ScummVM using Visual C++ 2015, the final link step to build
 scummvm.exe fails with 2 unresolved external symbol errors from
 sci.lib(message.obj) for "int *
 STATIC_ASSERT_uint16_can_only_be_read_from_int16_or_smaller_spans".

 STATIC_ASSERT looks to be a macro (defined in common/scummsys.h) which
 tries to emulate C++11 "static_assert" (which works fine in MSVC 2015),
 but it's not working correctly here.

 Oddly, if I try using the STATIC_ASSERT macro in a test program, it seems
 to work fine, aside from assertion failures showing up as "negative
 subscript" instead of the message provided.

--
Ticket URL: <https://bugs.scummvm.org/ticket/10154>
ScummVM <https://bugs.scummvm.org>
ScummVM