[Scummvm-tracker] [ScummVM] #9709: Graphics::ManagedSurface::transBlit() assumes source rectangle starts at (0, 0) when blitting. Should it?

[Torbjörn Andersson]

#9709: Graphics::ManagedSurface::transBlit() assumes source rectangle starts at
(0, 0) when blitting. Should it?
-------------------------+-----------------------
Reporter:  eriktorbjorn  |      Owner:  (none)
    Type:  defect        |     Status:  new
Priority:  normal        |  Component:  --Other--
Keywords:                |       Game:
-------------------------+-----------------------
 I'm using Starship Titanic as an example: If you pick up and drag the CD
 at the start of the game, and try to drag it to the left or top edge of
 the screen, the object is cut off and the right and bottom respectively,
 rather than clipped to the screen.

 This appears to be because transBlit() in ManagedSurface assumes that the
 source rectangle always starts at (0, 0) so all it has to do is check its
 width and height. Is this the desired behavior?

 I'm attaching a proof-of-concept patch that Works For Me(tm) in this
 particular case.

--
Ticket URL: <https://bugs.scummvm.org/ticket/9709>
ScummVM <https://bugs.scummvm.org>
ScummVM