[Scummvm-tracker] [ScummVM] #9700: SCI: Audio settings sync is not quite right

[Colin Snover]

#9700: SCI: Audio settings sync is not quite right
--------------------+-------------------------
Reporter:  csnover  |      Owner:  (none)
    Type:  defect   |     Status:  new
Priority:  normal   |  Component:  Engine: SCI
Keywords:           |       Game:
--------------------+-------------------------
 Volume changes are automatically synchronised to ScummVM whenever
 `kDoSound` and `kDoAudio` volume subops are invoked, but these ops are
 used by game scripts during the normal course of a game, not just by the
 user changing audio settings. As a result, syncing whenever the volume is
 changed via these kernel calls can cause the user’s audio settings to be
 broken. For example, quitting a game in the middle of speech will cause
 the normal music volume level to be restored at the reduced speech volume
 level.

 So, the only time that the audio settings should be synchronised from the
 game is when the user is actually interacting with the in-game audio
 settings. There is no 100% consistent way to check this across all
 engines, but I will elaborate on potential approaches I have discovered so
 far in the comments on this ticket, in case anything sounds particularly
 good or particularly bad.

--
Ticket URL: <https://bugs.scummvm.org/ticket/9700>
ScummVM <https://bugs.scummvm.org>
ScummVM