[Scummvm-tracker] [ScummVM] #9943: MOHAWK: Riven: 'confirm_exit' option displays dialog when game ends.

[macca8]

#9943: MOHAWK: Riven: 'confirm_exit' option displays dialog when game ends.
-------------------+----------------------------
Reporter:  macca8  |      Owner:  (none)
    Type:  defect  |     Status:  new
Priority:  normal  |  Component:  Engine: Mohawk
Keywords:          |       Game:  Riven
-------------------+----------------------------
 This is an unusual bug in that the feature it refers to isn't standard for
 Riven.

 With the recent overhaul of the Riven engine, the 'confirm_exit' option
 now intercepts the automatic quit generated when the game ends (didn't
 previously), displaying an unnecessary dialog to the player.

 For the record, clicking Quit closes both Riven and ScummVM as expected,
 however clicking Cancel relaunches the end game.

 Having said that, the pertinent issue here is that the dialog shouldn't
 appear.

 To reproduce:
 - manually add the line 'confirm_exit=true' to the ScummVM section of the
 Config File.
 - using the attached saved game, press the button beside the telescope to
 launch the end game.
 Note that any end game can be used for this test.

 I've added this option to the Config File because Riven doesn't currently
 offer a 'Prompt to Save' feature (unlike the original, which does). It
 provides the first part of the required functionality (the second part is
 to return to the in-game menu to complete the save) by intercepting player
 exit calls (Quit, Return to Launcher, but NOT Load) for a game in
 progress, and continues to do so.

 Hopefully a proper 'Prompt to Save' feature can be added in the near
 future.

 Current Daily Build: 1.10.0git3775-geb73062 (11 July 2017)
 Last known without bug: 1.10.0git3512-gdeab63f (21 June 2017)
 Game Version: English, 5-CD (contains v1.02 patch files)
 Platform: Intel Mac (OS X 10.6.8)

--
Ticket URL: <https://bugs.scummvm.org/ticket/9943>
ScummVM <https://bugs.scummvm.org>
ScummVM