[Scummvm-tracker] [ScummVM] #10022: TITANIC: Crash if open house view for star puzzle before inserting picture in

[dafioram]

#10022: TITANIC: Crash if open house view for star puzzle before inserting picture
in
---------------------+------------------------------
Reporter:  dafioram  |      Owner:  (none)
    Type:  defect    |     Status:  new
Priority:  normal    |  Component:  Engine: Titanic
Keywords:            |       Game:  Starship Titanic
---------------------+------------------------------
 Scummvm: 1.10.0git-4120-g720e146
 Game: Titanic ver C.
 OS: Win7-64

 When going to solve the star puzzle you are supposed to enter in your
 picture and that lets you see the stars around your house. If you don't
 and you enter into the machine and you quickly press **Tab** then the game
 crashes. You can't access the house view by clicking on the picture you
 have to hit **Tab**. This will produce the backtrace below. The original
 does not crash here.

 {{{
 #0  0x000000000055f37b in Titanic::CSurfaceFader::draw (this=0x1fb52c0,
     screenManager=0x1519170, srcSurface=0x0)
     at engines/titanic/star_control/surface_fader.cpp:72
 #1  0x000000000055c944 in Titanic::CStarView::draw (this=0x1fb5040,
     screenManager=0x1519170) at
 engines/titanic/star_control/star_view.cpp:84
 #2  0x0000000000549247 in Titanic::CStarControl::draw (this=0x1faac20,
     screenManager=0x1519170)
     at engines/titanic/star_control/star_control.cpp:86
 #3  0x0000000000587f69 in Titanic::CMainGameWindow::drawViewContents (
     this=0x151b290, screenManager=0x1519170)
     at engines/titanic/main_game_window.cpp:222
 #4  0x0000000000587d52 in Titanic::CMainGameWindow::draw (this=0x151b290)
     at engines/titanic/main_game_window.cpp:173
 #5  0x000000000058611e in Titanic::CSTGameView::draw (this=0xdf0470,
     bounds=...) at engines/titanic/game_view.cpp:93
 #6  0x0000000000583a22 in Titanic::CGameManager::update (this=0x1a8e650)
     at engines/titanic/game_manager.cpp:207
 #7  0x0000000000588092 in Titanic::CMainGameWindow::onIdle
 (this=0x151b290)
     at engines/titanic/main_game_window.cpp:248
 #8  0x00000000005823f1 in Titanic::Events::checkForNextFrameCounter (
     this=0x15190b0) at engines/titanic/events.cpp:126
 #9  0x0000000000581f95 in Titanic::Events::pollEvents (this=0x15190b0)
     at engines/titanic/events.cpp:40
 #10 0x000000000058230a in Titanic::Events::pollEventsAndWait
 (this=0x15190b0)
     at engines/titanic/events.cpp:108
 #11 0x000000000045d3e9 in Titanic::TitanicEngine::run (this=0x14d0730)
     at engines/titanic/titanic.cpp:144
 #12 0x000000000040e00e in runGame (plugin=0xce3f90, system=...,
     edebuglevels=...) at base/main.cpp:263
 #13 0x000000000040f1d1 in scummvm_main (argc=1, argv=0x7fffffffdf48)
     at base/main.cpp:529
 #14 0x000000000040c17e in main (argc=1, argv=0x7fffffffdf48)
     at backends/platform/sdl/posix/posix-main.cpp:45
 }}}

 Now if you are slow in clicking tab then it will switch to the house view
 and not crash, but if you leave the machine in that view and reenter it
 then it will crash, but at a slightly different part of the code:

 {{{
 #0  0x000000000055f1c6 in Titanic::CSurfaceFader::setupSurface (
     this=0x1fb6370, screenManager=0x151a060, srcSurface=0x0)
     at engines/titanic/star_control/surface_fader.cpp:48
 #1  0x000000000055f353 in Titanic::CSurfaceFader::draw (this=0x1fb6370,
     screenManager=0x151a060, srcSurface=0x0)
     at engines/titanic/star_control/surface_fader.cpp:69
 #2  0x000000000055c944 in Titanic::CStarView::draw (this=0x1fb60f0,
     screenManager=0x151a060) at
 engines/titanic/star_control/star_view.cpp:84
 #3  0x0000000000549247 in Titanic::CStarControl::draw (this=0x1fabcd0,
     screenManager=0x151a060)
     at engines/titanic/star_control/star_control.cpp:86
 #4  0x0000000000587f69 in Titanic::CMainGameWindow::drawViewContents (
     this=0x151c180, screenManager=0x151a060)
     at engines/titanic/main_game_window.cpp:222
 #5  0x0000000000587d52 in Titanic::CMainGameWindow::draw (this=0x151c180)
     at engines/titanic/main_game_window.cpp:173
 #6  0x000000000058611e in Titanic::CSTGameView::draw (this=0x19ca350,
     bounds=...) at engines/titanic/game_view.cpp:93
 #7  0x0000000000583a22 in Titanic::CGameManager::update (this=0x1a8f630)
     at engines/titanic/game_manager.cpp:207
 #8  0x0000000000588092 in Titanic::CMainGameWindow::onIdle
 (this=0x151c180)
     at engines/titanic/main_game_window.cpp:248
 #9  0x00000000005823f1 in Titanic::Events::checkForNextFrameCounter (
     this=0x1519fa0) at engines/titanic/events.cpp:126
 #10 0x0000000000581f95 in Titanic::Events::pollEvents (this=0x1519fa0)
     at engines/titanic/events.cpp:40
 #11 0x000000000058230a in Titanic::Events::pollEventsAndWait
 (this=0x1519fa0)
     at engines/titanic/events.cpp:108
 #12 0x000000000045d3e9 in Titanic::TitanicEngine::run (this=0x14d19f0)
     at engines/titanic/titanic.cpp:144
 #13 0x000000000040e00e in runGame (plugin=0xcb8b50, system=...,
     edebuglevels=...) at base/main.cpp:263
 #14 0x000000000040f1d1 in scummvm_main (argc=1, argv=0x7fffffffdf48)
     at base/main.cpp:529
 #15 0x000000000040c17e in main (argc=1, argv=0x7fffffffdf48)
     at backends/platform/sdl/posix/posix-main.cpp:45
 }}}

--
Ticket URL: <https://bugs.scummvm.org/ticket/10022>
ScummVM <https://bugs.scummvm.org>
ScummVM