[Scummvm-tracker] [ScummVM] #9843: SCI: KQ7 Win ES: White is drawn as black in videos (was: SCI: KQ7: spanish Windows version: cutscenes: only snipped displayed / wrong palette)

[Colin Snover]

#9843: SCI: KQ7 Win ES: White is drawn as black in videos
-----------------------------+-------------------------
  Reporter:  Bakhtosh        |      Owner:  (none)
      Type:  defect          |     Status:  new
  Priority:  normal          |  Component:  Engine: SCI
Resolution:                  |   Keywords:  sci32
      Game:  King's Quest 7  |
-----------------------------+-------------------------

Comment (by csnover):

 Thanks for your report! The KQ7 videos in CRAM format are encoded with
 palette entry 0 as white, which conflicts with the SCI palette where entry
 0 is black. This worked in the original interpreter because the videos
 were actually rendered outside the SCI process using MCI, so the different
 palettes did not conflict. In ScummVM, we render the videos to the same
 surface as the rest of SCI for simplicity’s sake, so the black & white
 palette entries cannot conflict as they do here.

 There is already a workaround in ScummVM that fixes the problem in KQ7 1.x
 by remapping these pixels; this workaround just was not applied to 2.00b
 because that (English) version of the game used Cinepak, so it did not
 seem to be relevant. To fix this bug, this workaround just needs to be
 improved with a better criteria, like actually looking at the video data
 instead of just assuming the palette needs fixing based on the interpreter
 version.

 The other problem mentioned in this ticket regarding the incorrect video
 dimensions is the same bug as #9762, so please watch there for updates on
 that bug.

--
Ticket URL: <https://bugs.scummvm.org/ticket/9843#comment:2>
ScummVM <https://bugs.scummvm.org>
ScummVM