[Scummvm-tracker] [ScummVM] #9855: SCI: PQ4: Spaceship collision with asteroids not working

[bluegr]

#9855: SCI: PQ4: Spaceship collision with asteroids not working
-----------------------------+-------------------------
  Reporter:  bgK             |      Owner:  (none)
      Type:  defect          |     Status:  new
  Priority:  normal          |  Component:  Engine: SCI
Resolution:                  |   Keywords:  sci32
      Game:  Police Quest 4  |
-----------------------------+-------------------------

Comment (by bluegr):

 The scene in question is 2010.

 This probably the only SCI32 game which actually uses the kObjectIntersect
 kernel function, in this particular scene.

 The issue is that our current implementation of this function uses SCI16
 code, and yields wrong results. I'm attaching a patch that is what the
 original SCI21 interpreter is doing. The function itself works fine,
 however sometimes there's an assertion thrown in celobj32.cpp:325, in
 READER_Compressed, function getRow(), but it looks to be random.

 I've also managed to reproduce an uninitialized read error when I died
 once while an enemy ship was present:
 Uninitialized read for temp 7 from method enemyShip1::cantBeHere (room
 2010, script 2010, localCall ffffffff)

--
Ticket URL: <https://bugs.scummvm.org/ticket/9855#comment:1>
ScummVM <https://bugs.scummvm.org>
ScummVM