[Scummvm-tracker] [ScummVM] #10277: TITANIC: Use of uninitialised variable

[Colin Snover]

#10277: TITANIC: Use of uninitialised variable
--------------------+------------------------------
Reporter:  csnover  |      Owner:  (none)
    Type:  defect   |     Status:  new
Priority:  normal   |  Component:  Engine: Titanic
Keywords:           |       Game:  Starship Titanic
--------------------+------------------------------
 {{{
 scummvm/engines/titanic/true_talk/tt_npc_script.cpp:313:10: warning:
 variable 'rangeLimit' is used uninitialized whenever 'if' condition is
 false [-Wsometimes-uninitialized]
                                         if (dialRegion != 1) {
                                             ^~~~~~~~~~~~~~~
 scummvm/engines/titanic/true_talk/tt_npc_script.cpp:320:63: note:
 uninitialized use occurs here
                                 dialogueId = ((remainder + _quotes._incr)
 % 100) >= (uint)rangeLimit
 ^~~~~~~~~~
 scummvm/engines/titanic/true_talk/tt_npc_script.cpp:313:6: note: remove
 the 'if' if its condition is always true
                                         if (dialRegion != 1) {
                                         ^~~~~~~~~~~~~~~~~~~~~
 scummvm/engines/titanic/true_talk/tt_npc_script.cpp:309:19: note:
 initialize the variable 'rangeLimit' to silence this warning
                                 int rangeLimit;
                                               ^
                                                = 0
 }}}

 Build: 8d555acc0dcc2c32fee1250b8ae9c7b7020e24ea

--
Ticket URL: <https://bugs.scummvm.org/ticket/10277>
ScummVM <https://bugs.scummvm.org>
ScummVM