[Scummvm-tracker] [ScummVM] #10153: TITANIC: Star locking/unlocking via green lights, differences

[dafioram]

#10153: TITANIC: Star locking/unlocking via green lights, differences
-------------------------------+-----------------------------
  Reporter:  dafioram          |      Owner:  dreammaster
      Type:  defect            |     Status:  closed
  Priority:  low               |  Component:  Engine: Titanic
Resolution:  fixed             |   Keywords:
      Game:  Starship Titanic  |
-------------------------------+-----------------------------

Comment (by dafioram):

 As a part of the implementation of the fix for #10170, I wasn't sure
 exactly when the code was done executing a lock, but for sure it was done
 when the user tried to move the view with their mouse in
 CStarCamera::setViewportAngle. So that is why you are seeing the behavior
 of the unlocking/locking not working until there is movement in the screen
 area.

 So if where you have inserted the unlocking flag,
 CStarCamera::removeMover(), is sooner than the unlocking in the beginning
 of CStarCamera::setViewportAngle, but after the locking process has
 concluded then the unlock flag being set in StarCamera::setViewportAngle
 can be removed.

 Looking at the code it looks like removeMover() only gets called in
 CStarCamera's destructor and specifically when 3 stars are not locked, so
 the unlocking not working for no mouse movement in the screen area should
 still be an issue for when 3 stars are locked.

--
Ticket URL: <https://bugs.scummvm.org/ticket/10153#comment:3>
ScummVM <https://bugs.scummvm.org>
ScummVM