[Scummvm-tracker] [ScummVM] #10228: SCI: SQ4: Windows-specific SFX don't play

Martin Kiewitz trac at scummvm.org
Mon Sep 25 00:50:37 CEST 2017


#10228: SCI: SQ4: Windows-specific SFX don't play
----------------------------+-------------------------
  Reporter:  EricOakford    |      Owner:  (none)
      Type:  defect         |     Status:  new
  Priority:  normal         |  Component:  Engine: SCI
Resolution:                 |   Keywords:
      Game:  Space Quest 4  |
----------------------------+-------------------------

Comment (by m-kiewitz):

 Added bugfix/enhancement with commit d9dfca2

 Please test it out, if possible.

 I had one assert() at one time about a file already being closed, but I
 couldn't switch to VC++ to debug it. I was unable to reproduce it
 afterwards and even if it had something to do with this, it would be an
 engine bug and should be fixed in any case.

 I added it regardless of the chosen platform, so the game uses the
 enhanced and additional samples all the time now.

 We already do this for Space Quest 3 (original DOS interpreter didn't play
 samples, although samples were included with the game).

 We can add a game option in case someone wishes to disable this behavior,
 but right now I don't see a reason. We normally try to deliver the best
 version possible and those samples were meant to be played. The DOS
 interpreter was afaik simply not capable of playing multiple samples at
 the same time just like the Space Quest 3 DOS interpreter was incapable of
 playing any samples and no one has complained about that one (as far as I
 know).

--
Ticket URL: <https://bugs.scummvm.org/ticket/10228#comment:3>
ScummVM <https://bugs.scummvm.org>
ScummVM


More information about the Scummvm-tracker mailing list