[Scummvm-tracker] [ScummVM] #10683: MOHAWK: MYST: Assertion failure due to recent cos/sin table changes

[Lothar Serra Mari]

#10683: MOHAWK: MYST: Assertion failure due to recent cos/sin table changes
---------------------+----------------------------
Reporter:  lotharsm  |      Owner:  (none)
    Type:  defect    |     Status:  new
Priority:  high      |  Component:  Engine: Mohawk
Keywords:            |       Game:  Myst
---------------------+----------------------------
 The recent cos/sin table changes introduced a regression that leads to an
 assertion failure in MYST when trying to start a new game. The assertion
 failure happens right after the start of the game, where the intro movie
 is supposed to be played.

 git bisect results:

 {{{
 commit 9cfc70e7fe881cfbd680322b6beeb9a7ab7149c3
 Author: David Fioramonti <dafioram at gmail.com>
 Date:   Thu Aug 16 06:37:10 2018 -0700

     COMMON: allow cos/sin number of points to be more flexible

     Previously, the cos/sin table had to be a power of 2, but there
     are many use cases where the number of points is not necessarily
     a power of 2 so this change the constructor so it now takes
     in the number of points rather than the number of points as the
     exponent of a power of 2.

     The restriction is that the size must be divisible by 4.

 :040000 040000 73b87a157764d21e9d3c1a2fad1ddea4b3217862
 0e97da067fd291113e353ccf4279da97bc89d680 M      common
 }}}

--
Ticket URL: <https://bugs.scummvm.org/ticket/10683>
ScummVM <https://bugs.scummvm.org>
ScummVM