[Scummvm-tracker] [ScummVM] #10844: QFG4: Ad Avis' death is interrupted, he returns and kills hero

[Vhati]

#10844: QFG4: Ad Avis' death is interrupted, he returns and kills hero
--------------------------------+----------------------------
  Reporter:  Vhati              |      Owner:  (none)
      Type:  defect             |     Status:  new
  Priority:  normal             |  Component:  Engine: SCI
Resolution:                     |   Keywords:  SCI32 original
      Game:  Quest for Glory 4  |
--------------------------------+----------------------------

Comment (by Vhati):

 There's another lethal timer scheduled when hero tells the Ultimate Joke.
 \\
 \\
 CD, script 730 - sUltimateJoke::changeState()
 {{{
 (3
         (avis setLoop: 1 1 setCycle: Fwd)
         (switch g439_mySkillSlider
                 (1 (= seconds 55))
                 (2 (= seconds 45))
                 (3 (= seconds 30))
         )
 )
 (4
         (avis
                 view: 677
                 setLoop: 0 1
                 setCel: 0
                 setCycle: CT 5 1 self
         )
 )
 }}}
 The other timer will always end the game before this cues.
 Would've been an identical fireball death anyway.
 \\
 \\
 Floppy, script 730 - sUltimateJoke::changeState()
 {{{
 (3
         (avis setLoop: 1 1 setCycle: Fwd)
         (switch global439
                 (1 (= seconds 30))
                 (2 (= seconds 15))
                 (3 (= seconds 10))
         )
 )
 (4
         (avis
                 view: 677
                 setLoop: 0 1
                 setCel: 0
                 setCycle: CT 5 1 self
         )
 )
 }}}
 \\
 \\
 This joke timer's redundant.
 It'd be better to unconditionally dispose() it in state 3 and forgo the
 fireball stuff.

--
Ticket URL: <https://bugs.scummvm.org/ticket/10844#comment:4>
ScummVM <https://bugs.scummvm.org>
ScummVM