[Scummvm-tracker] [ScummVM] #10846: QFG4: Reading 5, Card lands on pile and falls through

[Vhati]

#10846: QFG4: Reading 5, Card lands on pile and falls through
--------------------------------+----------------------------
  Reporter:  Vhati              |      Owner:  (none)
      Type:  defect             |     Status:  new
  Priority:  low                |  Component:  Engine: SCI
Resolution:                     |   Keywords:  SCI32 original
      Game:  Quest for Glory 4  |
--------------------------------+----------------------------

Comment (by Vhati):

 Each card is created and placed by sSetTheSignificator, with local0 used
 to pass the desired card view as an argument. The resulting object is
 stored in local1.
 \\
 \\
 script 475 - sFifthReading::changeState()
 {{{
 (29
         # "The Falling Tower"
         (= loc0_myCardView 1031)
         (g0_hero setScript: sSetTheSignificator)
 )
 (30
         (g91_gloryMessager say: 1 6 69 0 self)
 )
 (31
         # "Six of Swords"
         (= loc0_myCardView 1048)
         (g0_hero setScript: sSetTheSignificator)
 )
 (32
         (loc1_myCard setPri: 1)
         (g91_gloryMessager say: 1 6 68 0 self)
 )
 (33
         (g0_hero setScript: sFadeIt)
 )
 }}}
 \\
 \\
 script 475 - sSetTheSignificator::changeState()
 {{{
 (0
         (UpdatePlane
                 ((g2_myCurrentRoom plane?) back: 29 picture: -1 yourself:)
         )
         ((= loc1_myCard (aTurnCard new:))
                 view: local0
                 posn: 148 189
                 init:
                 moveSpeed: 0
                 setPri: 12
                 setStep: 30 10
                 setScaler: Scaler 100 100 189 0
         )
         (= seconds 2)
 )
 (1
         (loc1_myCard
                 moveSpeed: 0
                 setStep: 30 10
                 setScaler: Scaler 100 35 189 110
                 setMotion: MoveTo 145 110 self
         )
 )
 (2 (= seconds 1))
 (3
         ((g2_myCurrentRoom script?) cue:)
         (sSetTheSignificator dispose:)
 )
 }}}

 When a card is initially dealt, it has priority 12.

 After it lands, setPri() assigns something lower (0,1,2).
 \\
 \\
 "The Falling Tower" is not getting assigned a new priority.
 "Six of Swords" is getting assigned priority 1.

 Assigning a higher priority to Swords would require making room.
 "push1" is one byte. "pushi 13" is two.

 So would inserting the missing low priority send to Tower.

 However, by dropping the setPri() for "Six of Swords" altogether, they'll
 both have priority 12. The most recent one will be displayed on top. This
 is followed by a table-clearing fade, so there will be no other low-
 priority cards to worry about.

--
Ticket URL: <https://bugs.scummvm.org/ticket/10846#comment:3>
ScummVM <https://bugs.scummvm.org>
ScummVM