[Scummvm-tracker] [ScummVM] #10397: FULLPIPE: Memory leak when loading a saved game

[dafioram]

#10397: FULLPIPE: Memory leak when loading a saved game
---------------------+------------------------------
Reporter:  dafioram  |      Owner:  (none)
    Type:  defect    |     Status:  new
Priority:  low       |  Component:  Engine: Fullpipe
Keywords:            |       Game:  Full Pipe
---------------------+------------------------------
 cf1171d4d9b43eba525439da82db16cd4aac0414

 Running valgrind:

 Loading a save via gmm:

 {{{
 ==19513== 44,248 (112 direct, 44,136 indirect) bytes in 1 blocks are
 definitely lost in loss record 2,490 of 2,490
 ==19513==    at 0x4C2E19F: operator new(unsigned long) (in
 /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
 ==19513==    by 0x1B1801: Fullpipe::createObject(int) (utils.cpp:320)
 ==19513==    by 0x1B336D: Fullpipe::MfcArchive::parseClass(bool*)
 (utils.cpp:410)
 ==19513==    by 0x1B39C2: Fullpipe::MfcArchive::readBaseClass()
 (utils.cpp:375)
 ==19513==    by 0x1A791C: readClass<Fullpipe::GameVar> (utils.h:66)
 ==19513==    by 0x1A791C: Fullpipe::GameLoader::readSavegame(char const*)
 (stateloader.cpp:87)
 ==19513==    by 0x16AF2B: Fullpipe::FullpipeEngine::loadGameState(int)
 (fullpipe.cpp:236)
 ==19513==    by 0x16BBEC: Fullpipe::FullpipeEngine::run()
 (fullpipe.cpp:286)
 ==19513==    by 0x158CA5: runGame (main.cpp:264)
 ==19513==    by 0x158CA5: scummvm_main (main.cpp:530)
 ==19513==    by 0x1532AD: main (posix-main.cpp:45)
 }}}

 Starting game and loading a save using in game menu (not gmm):

 {{{
 ==19982== 44,248 (112 direct, 44,136 indirect) bytes in 1 blocks are
 definitely lost in loss record 2,492 of 2,492
 ==19982==    at 0x4C2E19F: operator new(unsigned long) (in
 /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
 ==19982==    by 0x1B1801: Fullpipe::createObject(int) (utils.cpp:320)
 ==19982==    by 0x1B336D: Fullpipe::MfcArchive::parseClass(bool*)
 (utils.cpp:410)
 ==19982==    by 0x1B39C2: Fullpipe::MfcArchive::readBaseClass()
 (utils.cpp:375)
 ==19982==    by 0x1A61C7: readClass<Fullpipe::GameVar> (utils.h:66)
 ==19982==    by 0x1A61C7: Fullpipe::GameVar::load(Fullpipe::MfcArchive&)
 (stateloader.cpp:474)
 ==19982==    by 0x1B39DC: Fullpipe::MfcArchive::readBaseClass()
 (utils.cpp:378)
 ==19982==    by 0x1A61C7: readClass<Fullpipe::GameVar> (utils.h:66)
 ==19982==    by 0x1A61C7: Fullpipe::GameVar::load(Fullpipe::MfcArchive&)
 (stateloader.cpp:474)
 ==19982==    by 0x1B39DC: Fullpipe::MfcArchive::readBaseClass()
 (utils.cpp:378)
 ==19982==    by 0x1A61C7: readClass<Fullpipe::GameVar> (utils.h:66)
 ==19982==    by 0x1A61C7: Fullpipe::GameVar::load(Fullpipe::MfcArchive&)
 (stateloader.cpp:474)
 ==19982==    by 0x1B39DC: Fullpipe::MfcArchive::readBaseClass()
 (utils.cpp:378)
 ==19982==    by 0x1A6235: readClass<Fullpipe::GameVar> (utils.h:66)
 ==19982==    by 0x1A6235: Fullpipe::GameVar::load(Fullpipe::MfcArchive&)
 (stateloader.cpp:476)
 ==19982==    by 0x1B39DC: Fullpipe::MfcArchive::readBaseClass()
 (utils.cpp:378)
 }}}

 Start game and don't load a save:

 No memory leak.

--
Ticket URL: <https://bugs.scummvm.org/ticket/10397>
ScummVM <https://bugs.scummvm.org>
ScummVM