[Scummvm-tracker] [ScummVM] #3813: SPYFOX3 GERMAN: Crashes when entering ''hair-style'' room

[svenmeier]

#3813: SPYFOX3 GERMAN: Crashes when entering ''hair-style'' room
--------------------------+---------------------------
  Reporter:  SF/dorianpa  |      Owner:  Kirben
      Type:  defect       |     Status:  new
  Priority:  normal       |  Component:  Engine: SCUMM
Resolution:               |   Keywords:
      Game:  Spy Fox 3    |
--------------------------+---------------------------

Comment (by svenmeier):

 The problem is caused by a defect costume animation in the German version
 of the game:

 The hair-dresser room features an LED ticker with the German text "Perücke
 anfertigen".
 The corresponding custume animation ends with an AKC_Jump to location 846
 - the value FF47 present there is no valid control instruction, thus
 aḱos.cpp line 1751 ends the game with an error:

    Ending with undefined uSweat token FF47!

 It seems the original interpreter from LucasArts was more lenient for such
 cases, or the SpyFox engine contained a workaround.

 IMHO the easiest solution for this problem is to reset the animation to
 the start position of the costume, whenever such an "undefined uSweat
 token" is encountered.

 This doesn't need patching of the original game files, nor does it require
 to add any game-specific workaround to scummvm.

 I was able to continue the game; the LED ticker just starts over again,
 which seems to be exactly what was intended.

 I'll create a pull request.

--
Ticket URL: <https://bugs.scummvm.org/ticket/3813#comment:26>
ScummVM <https://bugs.scummvm.org>
ScummVM