[Scummvm-tracker] [ScummVM] #10568: SCI: PHANT1: Crash on startup

[Torbjörn Andersson]

#10568: SCI: PHANT1: Crash on startup
-------------------------------+-------------------------
  Reporter:  dafioram          |      Owner:  rsn8887
      Type:  defect            |     Status:  closed
  Priority:  blocker           |  Component:  Engine: SCI
Resolution:  fixed             |   Keywords:  sci32
      Game:  Phantasmagoria 1  |
-------------------------------+-------------------------

Comment (by eriktorbjorn):

 I could be wrong, but if I understand it correctly...

 Any game engine that uses the "advanced detector" will automatically
 maintain a "guioptions" setting for each game it handles. In my case, LSL7
 has

 {{{
 guioptions=sndNoMIDI noAspect gameOption2 gameOption9 gameOptionA
 gameOptionC lang_English
 }}}

 GAMEOPTION_LARRYSCALE is defined as GUIO_GAMEOPTIONS12, which has
 "gameOptionC" as its description. The checkGameGUIOption() function simply
 checks to see if a string contains the description for a specified option.
 So it should answer the question "should this game use the LarryScale
 option".

 I guess in your other example GUIO_LINKMUSICTOSFX means that adjusting
 sound effects volume should also adjust the music volume, or something
 like that. It's using it to see if a setting should be updated, rather
 than to see if it shold be queried, but I can't think of anything
 obviously wrong with that.

 So the proposed fix still feels right to me, though of course I wouldn't
 mind of someone could confirm it.

--
Ticket URL: <https://bugs.scummvm.org/ticket/10568#comment:13>
ScummVM <https://bugs.scummvm.org>
ScummVM