[Scummvm-tracker] [ScummVM] #10471: SFINX: ScummVM crashing during projector cutscene

[Thierry Crozat]

#10471: SFINX: ScummVM crashing during projector cutscene
---------------------+--------------------------
  Reporter:  Kriz1   |      Owner:  (none)
      Type:  defect  |     Status:  new
  Priority:  normal  |  Component:  Engine: CGE2
Resolution:          |   Keywords:
      Game:  Sfinx   |
---------------------+--------------------------

Comment (by criezy):

 Some more investigation: the crash happens on line 436 in
 engines/cge2/vga13h.cpp
 With the Polish version when it crashes we have  {{{maxnow}}} and
 {{{shpcnt}}} both equal to 23.
 With the English version for the same file we have {{{maxnow}}} equal to
 23 but {{{shpcnt}}} is equal to 24.

 After extracting the data I can indeed confirm that the number of phases
 differs between the polish and english version for the file 04tal200.spr

 Polish version:
 {{{
 [phase]
 dummy
 04tal202
 04tal203
 04tal204
 04tal205
 04tal206
 04tal207
 04tal208
 04tal209
 04tal210
 04tal211
 04tal212
 04tal213
 04tal214
 04tal215
 04tal216
 04tal217
 04tal218
 04tal219
 04tal220
 04tal221
 04tal222
 04tal223
 }}}

 English version:
 {{{
 [phase]
 dummy
 .Strangerke - the next line has been renamed from 04tal201 to 04tal202,
 because the file is missing in the original game data
 04tal202
 04tal202
 04tal203
 04tal204
 04tal205
 04tal206
 04tal207
 04tal208
 04tal209
 04tal210
 04tal211
 04tal212
 04tal213
 04tal214
 04tal215
 04tal216
 04tal217
 04tal218
 04tal219
 04tal220
 04tal221
 04tal222
 04tal223
 }}}

 As you can see there is also an interesting comment from Strangerke in the
 English version indicating that the file {{{04tal201}} does not exist (and
 indeed it doesn't), but this was handled differently between the Polish
 and English version. In the English version it was renamed to
 {{{04tal202}}}, which means we have two {{{04tal202}}} entries. For the
 Polish version is was removed (or was it ever there?) so we have one less
 phase.

 It seems to me the issue is with the Polish data file, so we may want to
 modify it in the same way as the English one and repackage it to provide a
 v1.1 Polish version.

--
Ticket URL: <https://bugs.scummvm.org/ticket/10471#comment:3>
ScummVM <https://bugs.scummvm.org>
ScummVM