[Scummvm-tracker] [ScummVM] #10788: SCI: GK1: Gabriel's mouth doesn't move during final CD scene

[sluicebox]

#10788: SCI: GK1: Gabriel's mouth doesn't move during final CD scene
-------------------------------+-------------------------
  Reporter:  sluicebox         |      Owner:  (none)
      Type:  defect            |     Status:  new
  Priority:  normal            |  Component:  Engine: SCI
Resolution:                    |   Keywords:
      Game:  Gabriel Knight 1  |
-------------------------------+-------------------------

Comment (by sluicebox):

 It's a bug in the name matching.

 ResourceManager::readResourcePatchesBase36() is looking for all sync36
 resources which start with the "#" character:
 SearchMan.listMatchingMembers(files, "#???????.???")

 The problem is that this ends up in Common::matchString() making the
 comparison, which treats "#" as a wildcard to mean any digit, and so it
 returns false and the sync36 patch files never get loaded.


 {{{
 case '#':
         if (!isDigit(*str))
                 return false;
         pat++;
         str++;
         break;
 }}}

--
Ticket URL: <https://bugs.scummvm.org/ticket/10788#comment:6>
ScummVM <https://bugs.scummvm.org>
ScummVM