[Scummvm-tracker] [ScummVM] #10792: SCI: Mac KQ6, QFG1VGA, FPFP, GK1 broken, possibly others

[sluicebox]

#10792: SCI: Mac KQ6, QFG1VGA, FPFP, GK1 broken, possibly others
----------------------+-------------------------
Reporter:  sluicebox  |      Owner:  (none)
    Type:  defect     |     Status:  new
Priority:  normal     |  Component:  Engine: SCI
Keywords:             |       Game:
----------------------+-------------------------
 ScummVM 2.0 broke mac versions of all SCI games whose data files are in
 the "Data#" format instead of "RESOURCE.###" which is at least KQ6,
 QFG1VGA, FPFP, and GK1. They can't be started due to a breaking change in
 the mac resource loader.

 There's already bug #10440 for FPFP but I don't know if it's known that
 this affected multiple games in the 2.0 release and that a fix is
 available.

 csnover described the problem in the comments for #10440 and there's a
 commit in his working branch that fixes it by disabling mac resource fork
 validation:
 https://github.com/csnover/scummvm/commit/ca420e44167e5ee488b4ad547104fa6b976e6f1c

 I don't know if disabling validation is the right ultimate fix but I can
 confirm that applying this change allows these games to load again.
 (Except for GK1 which crashes for other reasons but at least it gets
 farther)

 Just wanted to get the state of things written down and on the radar.

--
Ticket URL: <https://bugs.scummvm.org/ticket/10792>
ScummVM <https://bugs.scummvm.org>
ScummVM